Add Rec2020 color space #42
Open
+134
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves linebender#20, now implementing all CSS Color Module Level 4 color spaces.
tomcur
commented
Nov 14, 2024
Comment on lines
+460
to
+472
| (2_785_571_537. / 1_677_558_947.) as f32, | ||
| (-985_802_650. / 1_677_558_947.) as f32, | ||
| (-122_209_940. / 1_677_558_947.) as f32, | ||
| ], | ||
| [ | ||
| (-4_638_020_506. / 37_238_079_773.) as f32, | ||
| (42_187_016_744. / 37_238_079_773.) as f32, | ||
| (-310_916_465. / 37_238_079_773.) as f32, | ||
| ], | ||
| [ | ||
| (-97_469_024. / 5_369_968_309.) as f32, | ||
| (-3_780_738_464. / 37_589_778_163.) as f32, | ||
| (42_052_799_795. / 37_589_778_163.) as f32, |
There was a problem hiding this comment.
Some more lily-gilding here. Debatable usefulness, as the transfer function parameters are reals not representable as rationals.
raphlinus
approved these changes
Nov 14, 2024
|
|
||
| fn transfer(x: f32) -> f32 { | ||
| if x.abs() < Rec2020::B * 4.5 { | ||
| x / 4.5 |
There was a problem hiding this comment.
Should be x * (1.0 / 4.5) for performance.
| if x.abs() < Rec2020::B { | ||
| x * 4.5 | ||
| } else { | ||
| (Rec2020::A * x.abs().powf(0.45) - Rec2020::A + 1.).copysign(x) |
There was a problem hiding this comment.
If you group it so it's (Rec2020::A - 1.) that's one fewer addition.
|
Oh, also please add your name to the AUTHORS list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20, now implementing all CSS Color Module Level 4 color spaces.